Buttons has no background which makes it possible to see text behind it.
NARUDESIGNS opened this issue · comments
When the page is scrolled to a particular threshold, the tool buttons sticks to the page, allowing other contents to scroll under them. However, the tag, table, horizontal line, center and youtube buttons all have no backgrounds which make it possible to see the text which they overlap.
I expect those buttons to have a background and maybe match other button styles like the bold, italics, blockquotes etc...
Here's what it looks like presently
Hi @NARUDESIGNS, that issue has been resolved in #710. I think you need to pull the recent changes for it to reflect on your local env.
Alright, thanks. I'd close this issue now (am I allowed to do that or just mentors can?).
Ok, thank you. I saw this was fixed by you. Well done ma'am!
Since you’re the author of the issue, you can close it too.
Alright, thanks.
Hi, @TildaDares trust you're good. I just checked https://publiclab.org/post again (which isn't my local environment), populated it with large lorem ipsum texts and this issue still exist.
Please check and confirm so I can reopen the issue and work on it.
Hi @NARUDESIGNS, I think the transparent background is because of the btn-outline-secondary class.
Yes, you're right, it has background property set to transparent in css. Should you place this as an FTO issue or I should go ahead and fix it by removing the background class property?
Should you place this as an FTO issue or I should go ahead and fix it by removing the background class property?
Either one works
If this issue is still open can I do this small task, it is my first open-source contribution.
Hi @NARUDESIGNS, has this issue been resolved?
No it hasn't, @RaviAnand111 can take on it since it's his first time contributing.
@TildaDares
Hi @RaviAnand111, I've assigned this issue to you. If you need any help, feel free to ask.
ok, thankyou
Hi @TildaDares I have forked and cloned the project, I did npm install then installed grunt and open the example/index.html file and I am able to change css in the dev tools section as well.
Can you please tell me what should I do now and in which file can I make changes in bootstrap or css.
@RaviAnand111 You need to change btn-outline-secondary to btn-light in this file
I have changed the btn-outline-secondary to btn-light, now what should I do.
git add . , git commit -m "btn-light added for transparent btn", then git push origin main,
then I have to create a PR,
is that all I have to do now ?
@RaviAnand111 You have to run grunt build before you create a PR.
ok, will do
I have created a PR after running grunt build,
PR #765