Jasmine test failures stopping progress
jywarren opened this issue · comments
Unfortunately, and unrelated to #683, we're seeing test errors blocking several/all PRs, including:
Hmm. I'm seeing a lot of this type of error:
- adds value to 'tags' key of editor.data, instead of overwriting it...
log: Failed to load resource: net::ERR_FILE_NOT_FOUND
...adds value to 'tags' key of editor.data, instead of overwriting it...X
Expected '' to be 'cool,rad'. (1)
>> Expected '' to be 'cool,rad'. Error: Expected '' to be 'cool,rad'.
>> at <Jasmine>
>> at UserContext.<anonymous> (file:///home/runner/work/PublicLab.Editor/PublicLab.Editor/spec/javascripts/tags_module_spec.js:32:28)
>> at <Jasmine>
Expected 'first,' to be 'first,cool,rad'. (2)
>> Expected 'first,' to be 'first,cool,rad'. Error: Expected 'first,' to be 'first,cool,rad'.
I wonder... near the top i see:
log: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
Oddly, other recent pull requests don't show this. #718
Also noting Jasmine tests overall are stalled: #741
Let's consider fixing via #743
Solved in #818!!!