ptitSeb / friking-shark

Port of Friking Shark (remake of Flying Shark) on the OpenPandora, Odroid and most Linux. Also with AmigaOS4 support. Status: Working (using gl4es).

Home Page:https://boards.openpandora.org/topic/5600375-friking-shark/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Treating warnings as errors causing compile to fail under Linux & gcc-4.5 in OpenGL code

GoogleCodeExporter opened this issue · comments

It seems like treating warnings as errors is turned on by default in the 
Makefile.

Lots of these types of errors in OpenGLShader.cpp, and one in OpenGLRender.cpp :

OpenGLShader.cpp:159:126: error: converting to non-pointer type 
‘GLhandleARB’ from NULL

It compiles fine if you use "(GLhandleARB) NULL".

Similar issues with needing to cast NULL to Colormap and Cursor in 
./GameGraphics/OpenGLViewport.cpp :

OpenGLViewport.cpp:263:15: error: converting to non-pointer type ‘Colormap’ 
from NULL
OpenGLViewport.cpp:264:19: error: converting to non-pointer type ‘Cursor’ 
from NULL
OpenGLViewport.cpp: In member function ‘virtual void 
COpenGLViewport::Destroy()’:
OpenGLViewport.cpp:538:21: error: converting to non-pointer type ‘Cursor’ 
from NULL
OpenGLViewport.cpp:551:17: error: converting to non-pointer type ‘Colormap’ 
from NULL

It looks to be compiling again successfully after casting these. Can't wait to 
have a go at this - it looks very nifty.

Cheers,
Dave.

Original issue reported on code.google.com by dgo...@gmail.com on 10 Jun 2011 at 10:56

Just saw the issue and was just going to sleep, let me review it, i received no 
mail, will check the config :)

Yep, i'm compiling by default with werror, pedantic and pedantic errors, good 
for me, but no so good when others are using other compiler versions :), sorry.

Original comment by javierma...@gmail.com on 12 Jun 2011 at 2:57

Original comment by javierma...@gmail.com on 12 Jun 2011 at 10:00

  • Changed state: Accepted

Original comment by javierma...@gmail.com on 12 Jun 2011 at 12:31

  • Changed state: Fixed