pthom / imgui_manual

https://pthom.github.io/imgui_manual_online - an interactive manual for ImGui

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"View on github at this line" version mismatch

dimateos opened this issue · comments

Hey! first of all thanks for all your work, is incredibly useful :)

I noticed that the "View on github at this line" button is targetting a different file than the interactive demo.

  • The demo shows v1.89.2, imported as part of the external imgui sub-module (at an specific commit).
  • But the button manually targets DemoCode branch inside your fork, which is at v1.86 WIP

This version mismatch is enough to make the button completely misaligned in most cases!

Anyway, the obviuous options to fix it:

  1. Make the sub-module match the hard coded URL in ImGuiRepoUrl.h, worst option as this imgui version is the oldest one.
  2. Make the hard coded URL match the current sub-module, easiest option and would provide an okay solution for now.
  3. Make the URL match the master default URL of your fork and potentially update it to the imgui version you consider. Although not sure why you didnt do it in the first place, so I guess you had your reasons.

Cheers!

Hey! first of all thanks for all your work, is incredibly useful :)

Thanks :-)

Thanks for mentioning this, I just fixed this. There was a mistake on the branch name.