psychs / limechat

IRC Client for Mac

Home Page:http://limechat.net/mac/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Certain URLs don't display or function correctly

p-i- opened this issue · comments

commented

https://books.google.pl/books?id=kkaaH3Q19Z4C&pg=PA177&lpg=PA177&dq="Inherited+ADdress+Space+%3D"&source=b

^ This URL displays as:

screen shot 2016-05-26 at 15 49 41

i.e. It is failing to underline past the = probably because the next character is a quote.

Also clicking the link shows that it is disregarding everything after the =

I wouldn't call this a bug. LimeChat doesn't use macOS's built-in NSDataDetector, but that class returns a similar result (only stopping after "dq" rather than "dq=").

The URL RFC specifically calls out " as an unsafe character (like a space character), since "the quote mark (""") is used to delimit URLs in some systems".

Where is this URL coming from? Safari/Firefox/Chrome are all clever enough to accept a URL with quotes, but to escape the quotes in their URL bar, either when you visit the page, or when you copy (cmd-C) the URL out of there.