przeor / react-router-flux-starter-kit

Why & How to Learn React Redux, the right highly scalable way.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Login.attemptedTransition assigned but never used

greenlaw110 opened this issue · comments

In AuthenticationMixin.js it assigned transition to Login.attemptedTransition static field:
image

However that static field is never used in the application. My hypothesis is it should be used in components/auth/login.js::componentDidUpdate:
image

Instead of direct the route to /dashboard, it shall check the attemptedTransition state and redirect to there if it's not null.

@greenlaw110 thanks. if you will do a pull request, then I will merge it. I see you already have fixed this part here: greenlaw110@f02f05d#diff-74fd7423691685207bf4b7a5e58e5b2cR17