prysmaticlabs / prysm

Go implementation of Ethereum proof of stake

Home Page:https://www.offchainlabs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace multiple `--<network>` flags by an unique `--network=<network>` flag.

nalepae opened this issue Β· comments

πŸš€ Feature Request

Description

Prysm CLI primarily defines networks using --<network> flags.
Currently, these flags include --mainnet, --sepolia and --holesky.

  • Each time a new network is added, a corresponding --<network> flag needs to be introduced..
  • When a network is retired, its --<network> flag must be removed.

Proposed Solution

Prysm should implement a single --network=<network> flag. Presently, this would include options --network=mainnet, --network=sepolia and --network=holesky.

  • Prior to the release of Prysm V7, both the --<network> flags and the --network=<network> flag should coexist.
  • If a--<network> flag is used, a WARN log should appear, indicating that this flag will be deprecated in Prysm V7 and the --network=<network> flag should be used instead.
  • If both the --network=<network> flag and a --<network> flag are used simultaneously, the program should not start.
  • Upon the release of Prysm V7, all --<network> flags should be removed.

Targeted programs

  • Beacon node
  • Validator client
  • prysmctl
commented

Can take this up

commented

@nalepae just noticed, there's already a chainId and NetworkID flags in the cmd/beacon-chain/flags/base.go

Am I supposed to replace it or just add it to other places