Wave new version of ios9.

Question

Wave new version of ios9.

Angelk90 opened this issue 6 years ago · comments

Angelk90 commented 6 years ago

@prscX :
Hi, it would be possible to have the same effect in the images you see below in the new version of ios9.

**KING** commented 6 years ago

Sure.

Pranav Raj Singh Chauhan · Answer 1 · Sun Feb 04 2018 13:37:46 GMT+0800 (China Standard Time)

Thanks @Angelk90 for raising the request.

Initially I had plans of integrating Siri Wave for iOS 9 as well, but I couldn't find any native library providing the same.

The library which you are referring to is a JS WebView based and we may end up in performance issues. However if you come across any such native library please feel free to raise PR or enhancement request for the same.

Thanks
Pranav

**KING** · Answer 2 · Wed Mar 21 2018 04:36:10 GMT+0800 (China Standard Time)

Hello
Recently, I've developed native module for iOS 9 Siri Wave.
Could u merge this with yours?

Pranav Raj Singh Chauhan · Answer 3 · Wed Mar 21 2018 09:07:08 GMT+0800 (China Standard Time)

Sure, Definitely. Can you please share the link of your module, I will integrate this on priority :smile, I am not able to find in your repositories.

Many Thanks for the module @GreatPotter.

Thanks
Pranav

Angelk90 · Answer 4 · Mon Mar 26 2018 18:01:45 GMT+0800 (China Standard Time)

Hi @prscX, there have been news about this module on the new version of ios9?

Pranav Raj Singh Chauhan · Answer 5 · Mon Mar 26 2018 19:09:40 GMT+0800 (China Standard Time)

Not Yet @Angelk90. Once @GreatPotter publish iOS 9 Siri we will integrate the same.

Thanks
Pranav

**KING** · Answer 6 · Tue Mar 27 2018 17:05:27 GMT+0800 (China Standard Time)

Hi @prscX
https://github.com/GreatPotter/SiriwaveIOS9
You could see my module there. I used your code basics.

Pranav Raj Singh Chauhan · Answer 7 · Tue Mar 27 2018 18:06:51 GMT+0800 (China Standard Time)

Thanks @GreatPotter for sharing the repo.

I have check and it is working as expected. Please find the screenshot below:

Can you please help me in order to understand the source implementation which you have made in order to achieve this:

Which classes contains your iOS9 wave implementation changes? Is it in SCSiriWaveformView.m or SiriWaveCurve.m class?
Are you planning to open source native iOS 9 wave implementation? or should I go forward and open source both?

Thanks
Pranav

**KING** · Answer 8 · Tue Mar 27 2018 19:07:42 GMT+0800 (China Standard Time)

I modified SCSiriWaveformView.m file and added
SiriWaveCurve.m, SiriWaveCurve.h files

Pranav Raj Singh Chauhan · Answer 9 · Tue Mar 27 2018 19:10:10 GMT+0800 (China Standard Time)

@GreatPotter: So should I integrate those changes in this library? If so we can plan to Open Source two libraries:

Native iOS 9 Siri Wave
Integrate Native iOS 9 Siri Wave into this library.

Please let me know your thoughts about the same.

Thanks
Pranav

**KING** · Answer 10 · Tue Mar 27 2018 19:15:40 GMT+0800 (China Standard Time)

Yes, I used Open Source Native libraries and added custom functionality.

Pranav Raj Singh Chauhan · Answer 11 · Tue Mar 27 2018 19:29:21 GMT+0800 (China Standard Time)

Hi @GreatPotter, Can you please provide the list of Open Source libraries which you have used in order to achieve this.

Thanks
Pranav

**KING** · Answer 12 · Tue Mar 27 2018 19:31:03 GMT+0800 (China Standard Time)

I used the same library as you used.

Pranav Raj Singh Chauhan · Answer 13 · Tue Mar 27 2018 19:35:06 GMT+0800 (China Standard Time)

@GreatPotter: So the same library you have modified in order to achieve this? If so can I Open Source it by crediting it on your name?

Thanks
Pranav

Pranav Raj Singh Chauhan · Answer 14 · Tue Mar 27 2018 19:37:37 GMT+0800 (China Standard Time)

Thanks @GreatPotter.

Thanks
Pranav

**KING** · Answer 15 · Tue Mar 27 2018 19:38:12 GMT+0800 (China Standard Time)

Thanks
Maik

Pranav Raj Singh Chauhan · Answer 16 · Wed Mar 28 2018 23:22:41 GMT+0800 (China Standard Time)

Hi @GreatPotter,

Many Thanks for the Siri Waveform 9 Implementation, I have integrated your implementation with this library. Now you will be able to use it by providing type prop as 1.

Hi @Angelk90,

With the help of @GreatPotter, I have enabled support for iOS Siri Wave 9. In order to use please install latest version 0.0.4 for the same.

V0.0.4

Please let me know in case you face any issues.

Thanks
Pranav

**KING** · Answer 17 · Wed Mar 28 2018 23:39:56 GMT+0800 (China Standard Time)

Hi @prscX

I hope collaborate with you at any time.

Thanks.
Maik

Pranav Raj Singh Chauhan · Answer 18 · Thu Mar 29 2018 06:06:09 GMT+0800 (China Standard Time)

Definitely @GreatPotter :smile. Please feel free to reach at any time.

Thanks
Pranav

**KING** · Answer 19 · Thu Oct 17 2019 02:14:04 GMT+0800 (China Standard Time)

Hi @prscX
It's great to see you again.
Recently, I changed my account name to k1115.
Could you change GreatPotter to k1115 on readme, please?