Giters

proudcity / wp-proudcity

The ProudCity WordPress platform

Home Page:https://proudcity.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Force ALT text on images

curtismchale opened this issue · comments

commented

Builds

Deploy ALT Text plugin

Source

CM

Describe the bug

ALT text should be forced on all instances of adding an image.

Adding image to Media Gallery

URL: https://beta.proudcity.com/wp-admin/upload.php

When you upload an image it should force you to put in ALT text in.

Inserting image to WP via the Classic Editor

When you choose an image from the media gallery it should prompt you for ALT text if there is none.

CleanShot 2024-05-02 at 13 16 33

CleanShot 2024-05-02 at 13 17 28

With Site Origin widgets

When you choose media it should auto-populate the existing ALT text and if there is none it should not allow you to insert the image.

Image Widget
CleanShot 2024-05-02 at 13 18 43

Image Set Widget

All images in the set should have ALT text and any that don't should have the issue highlighted if the user attempts to insert the content.

CleanShot 2024-05-02 at 13 20 44

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

QA

Notes:

Links:

commented

@curtismchale additional widgets that use images and should have alt text requirements:

  • Hero unit (all displays except simple heading)
  • Gallery
commented

All of these files come from the media library so my hope is that if we start with forcing alt text to be required when uploading the original, then alt text is addressed in all applications of the file.

commented

@kevindherman we can force ALT text in the media gallery when someone selects an image with the Fix ALT Text plugin.

This doesn't handle the ALT text in widgets as it won't fill in the text when you add an image but it will stop anyone from picking an image without ALT text so it would force older images to get the text and any new image would get it as well.

I'll have to build something custom to work with SiteOrigin widgets. Should I do that or stop here for now?

commented

@curtismchale can this at least be deployed to Petaluma?

I think getting this part on Petaluma would be a nice win then circle back for the rest with breathing room.

commented

@kevindherman is there a reason we wouldn't deploy it to all sites?

commented

@curtismchale all sounds better.

commented

@curtismchale @lukefretwell the plugin looks great and is definitely an improvement from what we had before.

I really like the reporting/fixing feature to help solve the problem.

commented

@kevindherman it's on Beta now and getting ready to go to all sites.

commented

@curtismchale this is great and I actually think this does everything we need.

  1. I added media in visual editor grabbing image file that was already uploaded and had no alt text, it required me to add it
  2. I added an image set and did the same as above
  3. I uploaded a new image for the image set and needed to add the alt text
  4. I added an image widget with the same experience.

I'm not sure the widget level alt text is needed but we can revisit.

It may be part of a followup but the plugin's reporting/fixing is really nice and could go under tools in our admin. I didn't see where to access and play around with those features so lets not have that hold this up.

Huge improvement as is. @lukefretwell

commented

@kevindherman yeah the settings UI is only available to PC Admins, but it doesn't match well with our Admin theme at all and would require a bunch of work to make it accessible to customers.

commented

makes sense. for another day then.