OGDL serializer problems
odisseus opened this issue · comments
Myroslav commented
1. Sorted set of sealed trait
sealed trait X
case class X1(foo: String) extends X
case class X2(bar: Int) extends X
implicit val ord3: Ordering[X] = Ordering[String].on[X](_.toString)
could not find implicit value for evidence parameter of type fury.ogdl.OgdlWriter[scala.collection.immutable.SortedSet[fury.test.OgdlWriterTest.X]]
2. List of single-field case class
case class Wrapper(value: String)
val input = List(Wrapper("foo"), Wrapper("bar"), Wrapper("baz"))
::=[{head=["foo"],tl=[::=[{head=["bar"],tl=[::=[{head=["baz"],tl=["Nil"]}]]}]]}]
Jon Pretty commented
Do we need this?
Myroslav commented
Not for the current state of the domain model. However, I got blocked by this deficiency when I attempted to re-implement #1382. If X
were a general type for a binary, X1
is a "managed binary", and X2
is a "supplied binary", these types would be impossible to serialize.
Jon Pretty commented
Ok, that makes sense. Let's not worry about it for now.
Jon Pretty commented
I'm going to close this because the serializers do everything we need them to at the moment.