prooph / event-store-symfony-bundle

Event Store Symfony Bundle

Home Page:http://getprooph.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecated relying on its factory's return-type to define the class of service

mkurzeja opened this issue · comments

In some environments I get the following error:

Relying on its factory's return-type to define the class of service "prooph_event_store.projection_manager.xxx_projection_manager" is deprecated since Symfony 3.3 and won't work in 4.0. Set the "class" attribute to "Prooph\EventStore\Projection\ProjectionManager" on the service definition instead: 1x

I assume the best solution is to add the class parameter when creating the service inside \Prooph\Bundle\EventStore\DependencyInjection\ProophEventStoreExtension::loadProjectionManagers

In some environments: each time when I run phpunit on my test suite and Symfony is building the dependency injection container - I get this error. Whats worse, phpunit is returning != 0 exit code.

I'm currently warming up the cache before running tests, but it would be great to fix this issue.