prontolabs / pronto

Quick automated code review of your changes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dotfiles are being ignored

KaoruDev opened this issue · comments

TLDR: dotfiles are ignored in exclude option, I believe the bug is here:

.flat_map { |path| Dir[path.to_s] }

and changing it to Dir.glob(path.tos, File::FNM_DOTMATCH)

According to: https://stackoverflow.com/questions/11385795/how-to-list-directory-contents-including-dotfiles-but-not-and

Steps to reproduce

I have the following structure:

.buildkite/src/
  package.json
  index.js
  .eslintrc.js
.eslintrc.json
packaage.json

And the following config:

all:
  exclude:
    - ".buildkite/**/*"

However, dotfile changes are still getting picked up by pronto.