Giters

prometheus / node_exporter

Exporter for machine metrics

Home Page:https://prometheus.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

node_exporter collector qdisc kingpin flag naming inconsistency

jbradleynh opened this issue · comments

commented

Host operating system: output of uname -a

Linux obs-stg-prometheus01 5.15.0-1035-gcp #43~20.04.1-Ubuntu SMP Mon May 22 16:49:11 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

node_exporter version: output of node_exporter --version

node_exporter, version 1.6.0 (branch: HEAD, revision: ff7f9d69b645cb691dd3e84dc3afc88f5c006962)
  build user:       root@f9c3ed0cfbd3
  build date:       20230527-12:03:54
  go version:       go1.20.4
  platform:         linux/amd64
  tags:             netgo osusergo static_build

Are you running node_exporter in Docker?

No

What did you do that produced an error?

Attempting to set devices to exclude from the qdisc collector. Their is a mixed naming for the collector kingpin flag, the assumed correct name would be qdisc, however some flags are labeled as qdisk

What did you expect to see?

--collector.qdisc.device-exclude=COLLECTOR.QDISC.DEVICE-EXCLUDE

What did you see instead?

node_exporter --help | grep qdis
      --collector.qdisc.fixtures=""
                                 test fixtures to use for qdisc collector
      --collector.qdisk.device-include=COLLECTOR.QDISK.DEVICE-INCLUDE
                                 Regexp of qdisk devices to include (mutually
      --collector.qdisk.device-exclude=COLLECTOR.QDISK.DEVICE-EXCLUDE
                                 Regexp of qdisk devices to exclude (mutually
      --[no-]collector.qdisc     Enable the qdisc collector (default: disabled).
commented

why this issue not closed after the fix code is merged?