prometheus / client_java

Prometheus instrumentation library for JVM applications

Home Page:http://prometheus.github.io/client_java/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

irregular syntax in content type

TomTriple opened this issue · comments

In

public final static String CONTENT_TYPE_OPENMETRICS_100 = "application/openmetrics-text; version=1.0.0; charset=utf-8";
you specified parameter version=1.0.0 which is not valid syntax according to https://www.w3.org/Protocols/rfc1341/4_Content-Type.html (it is not allowed to use . in an unquoted parameter value).

Please see also discussion here zio/zio-http#2416 (comment).

Valid syntax in this case should be version="1.0.0".

Thanks a lot! This is interesting: The content type String is literally copied out of the OpenMetrics spec:

The content type MUST be: application/openmetrics-text; version=1.0.0; charset=utf-8

Could you open an issue in the https://github.com/OpenObservability/OpenMetrics repo? I'm curious what they think.