projectunic0rn / travel-map-ui

Responsive/Interactive Map where users can record traves and see where their friends have been.

Home Page:https://geornal.herokuapp.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Responsiveness for Landing Page

Matt-Vance opened this issue · comments

Document issue details:

Mobile/Tablet:
-Login needs more margin-top
-Login form could be centered vertically

Login needs more margin-top

Would moving the close button to the same line with the "Login or Signup" line help with this?
E.g:
Screen Shot 2020-03-16 at 4 30 06 PM

-Login form could be centered vertically

Are you thinking about a popup with the Signin form centered ala Tap cities popup?
I am OK with the current design where the login form is optional.
I would like the Login form to disappear once the hamburger icon appears though since with smaller view-width, I would like more real estate dedicated to the website and only show login form on request.

Are you thinking about a popup with the Signin form centered ala Tap cities popup?

-- I think this is OK not being centered on desktop. On mobile I believe it is centered but if it is not then it should be

I am OK with the current design where the login form is optional.
I would like the Login form to disappear once the hamburger icon appears though since with smaller view-width, I would like more real estate dedicated to the website and only show login form on request.

-- Agreed, that is a good change

So basically the login in the menu (when you hit the hamburger icon) needs move vertical spacing/line height. And then for mobile the login/signup form needs to be centered (horizontally centered, vertical needs to account for the header so that it does not cover that up)

@GreenWithMV Are we all done with this issue?