Giters

projectunic0rn / travel-map-ui

Responsive/Interactive Map where users can record traves and see where their friends have been.

Home Page:https://geornal.herokuapp.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Linter Not Running in CircleCI

timimsms opened this issue · comments

commented

Issue Overview

What are you trying to do?

Have consistent code style checks on new code added to repository via pull requests.

What did you expect to happen?

Run ESLint on CircleCI without any errors.

What actually happened?

Failing to run on CircleCI
Seeing a number of errors locally

Steps to Reproduce

  1. Latest build attempt can be re-run here: https://app.circleci.com/pipelines/github/projectunic0rn/travel-map-ui/324/workflows/8d024ca2-1c0f-4940-b35b-da8e60727f10/jobs/327
  2. Can checkout this branch and run eslint .

Issue Details

Attached is a file with the current linter issues I'm seeing when running locally.

We may also need to get permission to use CircleCI Orbs within projectunic0rn as that seems like a more straight-forward option to running ESLint on CircleCI consistently.

Additionally, there is a chance that we are not actually "clean" with out code/linter, as it seems there may have been some inconsistencies in how this was setup/it has not been running on PR's for some time/may never have fully worked.

Not urgent, but definitely something we should address.

commented

@GreenWithMV let's look to touch base sometime next week on this as I imagine it's a bit of updating the config to better match your local environment/configuration as I know you mentioned you have not been seeing linter issues when running the project on your end.