Giters

projectunic0rn / pub

Where developers from around the world partner to build and ship software for fun, for learning, or for profit.

Home Page:https://projectunicorn.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Coverage reporting unnecessary for several build stages?

rmjordas opened this issue · comments

commented

The CI will run at least three (3) jobs for a specific build (more depending on the type, i.e. branch, pull_request, etc.):

  • npm run typecheck
  • npm run lint
  • npm test

But if any of them is successful, the will still push a report via the codecov package. This is an example for Job #822.1 which simply runs npm run typecheck:

Screenshot_2020-01-23 Job #822 1 - projectunic0rn pub - Travis CI

Notice the part where it says:

==> Scanning for reports

    X Failed to read file at

It didn't see any report because npm test was not run in this stage.

So, I think this is the reason why we have this:

Screenshot_2020-01-23 Fix TagTemplate pagination prefix by rmjordas · Pull Request #157 · projectunic0rn pub

@roymoran Will coverage reporting still work if we just run the codecov only on the stage that runs npm test?

commented

yeah you're right. it doesn't find the generated coverage report because those other stages/jobs don't run the test step. I'm working on adding the app version to the footer now and will make an adjustment to the travis file on that PR.