External HTTP connection issue
pixelbender opened this issue · comments
Seems other than 404 status codes leave unclosed resp.Body()
See:
https://github.com/progrium/viewdocs/blob/master/viewdocs.go#L115
https://github.com/progrium/viewdocs/blob/master/viewdocs.go#L215
@pixelbender If you have a chance, mind poking at where the updated versions of these unclosed resp.Body() instances are?
@josegonzalez
resp.Body can be nil here:
https://github.com/progrium/viewdocs/blob/master/viewdocs.go#L238
So just check for nil before we close it or...? (Sorry, I'm a bit under the weather, so not thinking too straight).
@josegonzalez sorry, the issue can be closed, here is the correct check now:
https://github.com/progrium/viewdocs/blob/master/viewdocs.go#L234-L236