progrium / viewdocs

Read the Docs meets Gist.io for simple Markdown project documentation

Home Page:http://viewdocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Image support?

BigBlueHat opened this issue · comments

Good point! Not sure the easiest way to implement though ... if anybody has
thoughts, let me know!

On Mon, Dec 22, 2014 at 3:25 PM, BigBlueHat notifications@github.com
wrote:

Would be super nice to include image loading via GitHub.

For example:
http://couchapp.viewdocs.io/couchapp/gettingstarted.md
vs.
https://github.com/couchapp/couchapp/blob/master/docs/gettingstarted.md

Thanks!


Reply to this email directly or view it on GitHub
#34.

Jeff Lindsay
http://progrium.com

Could HTTP requests fall back to the raw GitHub URLs if they 404 on viewdocs.io?

So the missing
http://couchapp.viewdocs.io/couchapp/imgs/gettingstarted01.png
would be served from
https://raw.githubusercontent.com/couchapp/couchapp/master/docs/imgs/gettingstarted01.png

Might make sense to limit this fallback to images, .pdf files, and the like--so the 404 unless you don't mind GitHub serving your 404's for you. 😉

Would prefer a non-proxy solution, but that's a reasonable one if nothing
better. :)

On Mon, Dec 22, 2014 at 4:04 PM, BigBlueHat notifications@github.com
wrote:

Could HTTP requests fall back to the raw GitHub URLs if they 404 on
viewdocs.io?

So the missing
http://couchapp.viewdocs.io/couchapp/imgs/gettingstarted01.png
would be served from

https://raw.githubusercontent.com/couchapp/couchapp/master/docs/imgs/gettingstarted01.png

Might make sense to limit this fallback to images, .pdf files, and the
like--so the 404 unless you don't mind GitHub serving your 404's for you. [image:
😉]


Reply to this email directly or view it on GitHub
#34 (comment).

Jeff Lindsay
http://progrium.com

This is probably best implemented by a solution to #21.