Implement Concrete distribution

Question

Implement Concrete distribution

alicanb opened this issue 7 years ago · comments

Alican Bozkurt commented 7 years ago

Fritz Obermeyer · Answer 1 · Tue Jan 09 2018 10:21:08 GMT+0800 (China Standard Time)

Duplicate of #2. See example implementation by @rachtsingh at pyro-ppl/pyro#588

Alican Bozkurt · Answer 2 · Tue Jan 09 2018 10:26:40 GMT+0800 (China Standard Time)

Sorry, my bad

Fritz Obermeyer · Answer 3 · Tue Jan 09 2018 10:52:58 GMT+0800 (China Standard Time)

It's nice that we're getting so much done we lose track of what remains 😉

Rachit Singh · Answer 4 · Tue Jan 09 2018 10:54:29 GMT+0800 (China Standard Time)

Ah yeah, let's port this after Bijectors land? I think I still need to write some tests, but the failures were PyTorch 0.3 stuff. Just looked over it, I was refactoring some of the Jacobian check code so that it's generic, and then using that both in the relaxed distributions and IAF.