privacy-scaling-explorations / zkevm-circuits

Home Page:https://privacy-scaling-explorations.github.io/zkevm-circuits/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

State circuit spec sync

ChihChengLiang opened this issue · comments

Describe the feature you would like

This issue collects the list of feedback to work on from privacy-scaling-explorations/zkevm-specs#520

The file to modify is zkevm-circuits/src/circuit_tools/constraint_builder.rs

  • value_prev and value_prev_column are confusing names. @rrtoledo Suggest renaming them to:
    • value_prev: WordLoHi<Expression>, // meta.query(value, Rotation::prev()) could be renamed value_rot_prev for instance
    • pub value_prev_column: WordLoHi<Expression>, // meta.query(prev_value, Rotation::cur()) be renamed value_prev
  • privacy-scaling-explorations/zkevm-specs#520 (comment)

TBD

Additional context

No response