privacy-scaling-explorations / zkevm-circuits

Home Page:https://privacy-scaling-explorations.github.io/zkevm-circuits/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[testool] Potential improvement

ChihChengLiang opened this issue · comments

Describe the feature you would like

Potential improvement 1: Make it works on the root directory.

Currently, the testool requires the user to cd into the directory to work, which is a little bit annoying. The reason that the change of directory is required is that it depends on file paths like tests/, codehash.txt, and Config.toml.

Potential improvement 2: reproducible script on testool report website

The report is on this website: http://testool-public.s3-website.eu-central-1.amazonaws.com/nightly.1708040362.cd5edab.html. It would be great we can copy-paste a command on the website to reproduce the error.

Potential improvement 3: Simply the suite

I am not sure what was the purpose of the distinction between the default and the nightly suite. I tried to reproduce a panic without specifying the --suite but it failed to find the test_id, which is located in the nightly suite.

Additional context

No response

commented

Another Potential improvement 4: report link support HTML hash tag

format: :

e.g.

http://testool-public.s3-website.eu-central-1.amazonaws.com/nightly.1708040362.cd5edab.html#invalidAddr_d54(ok)_g0_v0%23tests%2Fsrc%2FGeneralStateTestsFiller%2FstBadOpcode%2FinvalidAddrFiller.yml

So when raise issue we can easily target which test are targetting from the link

Sounds like a great idea! A html anchor would be super helpful!