api.previewSession syntax error

Question

api.previewSession syntax error

ds300 opened this issue 8 years ago · comments

At least I think this is a syntax error... previewSession binds a variable api and later refers to a self variable which, AFAICT, is supposed to be the same thing but has not been bound anywhere. This confuses me because no syntax errors are thrown when I use previewSession, but it doesn't work properly (the callback is never invoked/promise is never resolved). If I consolidate the bindings things work as expected.

I can submit a PR if you like.

Erwan Loisant · Answer 1 · Tue Mar 01 2016 00:44:01 GMT+0800 (China Standard Time)

thank you for the report, I'll fix it.

Erwan Loisant · Answer 2 · Tue Mar 01 2016 00:46:39 GMT+0800 (China Standard Time)

fixed in 2.1.1

David Sheldrick · Answer 3 · Tue Mar 01 2016 00:50:52 GMT+0800 (China Standard Time)

Thanks for the quick fix! 👍