transformSchema removes directives

Question

transformSchema removes directives

kbrandwijk opened this issue 7 years ago · comments

See apollographql/apollo-server#643 for more details.

Kim Brandwijk · Answer 1 · Fri Oct 27 2017 01:08:54 GMT+0800 (China Standard Time)

I think this might be caused by the fact that a new schema is created, instead of manipulating the schema that is passed in. https://github.com/graphcool/graphql-transform-schema/blob/master/src/index.ts#L18

Johannes Schickling · Answer 2 · Fri Oct 27 2017 22:01:07 GMT+0800 (China Standard Time)

Good catch @kbrandwijk. Would you mind creating a PR that additionally copies the directives as well?

Kim Brandwijk · Answer 3 · Fri Oct 27 2017 22:05:46 GMT+0800 (China Standard Time)

@schickling I think it's a bit more than that, because if you specify any custom directive in your schema, it doesn't automatically show up in the schema.getDirectives() result.

I think the necessary refactoring is to not create a new schema, but I'm not 100% sure how.