Fix: getVirtualPrice is incorrectly named

Question

Fix: getVirtualPrice is incorrectly named

Alexangelj opened this issue a year ago · comments

Description

The getVirtualPrice function is a semi-standardized way to let frontends query the price of one unit of a liquidity share. The implementation in Portfolio returns the REPORTED SPOT PRICE of the asset token. This could potentially mislead anyone who integrates Portfolio.

Clément Lakhal · Answer 1 · Fri May 05 2023 19:56:11 GMT+0800 (China Standard Time)

Would simply renaming the function to getSpotPrice work?

Clément Lakhal · Answer 2 · Sat May 06 2023 04:05:10 GMT+0800 (China Standard Time)

Done here https://github.com/primitivefinance/portfolio/tree/feat/add-getSpotPrice.

Clément Lakhal · Answer 3 · Sat May 06 2023 04:23:51 GMT+0800 (China Standard Time)

Closing this since the PR was merged.