Setup Subjects lib uses tokens that are in an array which is unclear
Alexangelj opened this issue · comments
Description
The setUp function in Setup will deploy multiple tokens sequentially and push them to an array of MockERC20 tokens. Accessing the specific tokens is then by index. If the order of these tokens deployed change in the setup (from an override), it could lead to some weird behavior in the test environment. The indexes should be variables and deployed to match the variable values. The variable values should be used in place of literals.
Closing for now since there's not an easy way to address this issue