primitivefinance / portfolio

Portfolio is an automated market making protocol for implementing custom strategies at the lowest cost possible.

Home Page:https://www.primitive.xyz/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix: Units are not descriptive in some functions or are poorly documented

Alexangelj opened this issue · comments

Description

  • Example: createPool accepts a "price" argument. This is missing a lot of information! Price with respect to what? Price for which asset? What units is price in? Is it wad or or is decimals? (it's WAD in terms of quote tokens per asset tokens).

Almost a duplicate of #269