[Bug] @primer/octicons-react: defaultProps is deprecated

[Alex Bates]

defaultProps was recently deprecated in React: see facebook/react#16210.

Using any Octicon produces something like the following warning:

Warning: UploadIcon: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

This is caused by the following code, which needs to be swapped out:

octicons/lib/octicons_react/src/createIconComponent.js

Line 45 in e05ddd3

 Icon.defaultProps = { 

[Andrés Bedoya (SrHart)]

That's right, I'm getting the same error, I think the solution is easy, just use default parameters in the Icon function, something like:

Icon({'aria-label': ariaLabel, tabIndex, className = defaultClassName, fill = 'currentColor', size = 16, verticalAlign = 'text-bottom'})

Or something like that...

[Rez]

Hey @nanaian, this should be fixed in the v17.10.1 release. Closing this for now, but feel free to reopen if you have any other questions.