try ... cacth never handle erlang:kill

Question

try ... cacth never handle erlang:kill

NOMORECOFFEE opened this issue 8 years ago · comments

Veselov Andrey commented 8 years ago

For example gen_rpc:call(<not_local_node>, timer, kill_after, [0])

Panagiotis PJ Papadomitsos · Answer 1 · Fri May 27 2016 18:27:42 GMT+0800 (China Standard Time)

I'm ok with that, that's not being handled by rpc:call either!

Veselov Andrey · Answer 2 · Fri May 27 2016 20:27:55 GMT+0800 (China Standard Time)

It isn't right. rpc:call return {badrpc,{'EXIT',killed}}

Veselov Andrey · Answer 3 · Fri May 27 2016 20:44:22 GMT+0800 (China Standard Time)

gen_rpc should use like in rpc https://github.com/erlang/otp/blob/maint/lib/kernel/src/rpc.erl#L200 or use middleman process https://github.com/erlang/otp/blob/maint/lib/kernel/src/rpc.erl#L338

Panagiotis PJ Papadomitsos · Answer 4 · Thu Jun 16 2016 03:59:37 GMT+0800 (China Standard Time)

This requires some pretty steep changes to deal with, including keeping track of workers, which creates garbage in the acceptor state and extra messages. Do you believe it's worth it?

Veselov Andrey · Answer 5 · Sat Jun 18 2016 21:12:35 GMT+0800 (China Standard Time)

Hi. If we don't set call_receive_timeout into infintity, then everything will be fine.

Veselov Andrey · Answer 6 · Sat Jun 18 2016 21:13:38 GMT+0800 (China Standard Time)

Or we can use another middleman process here and don't touch the acceptor state.

Veselov Andrey · Answer 7 · Sat Jun 18 2016 22:03:37 GMT+0800 (China Standard Time)

@priestjim I wanted to warn only about spawn_link/kill.

Panagiotis PJ Papadomitsos · Answer 8 · Mon Jun 20 2016 14:00:04 GMT+0800 (China Standard Time)

This is a real issue but affects very few of real world cases (making RPC calls on functions that use messages and self() such as timer:kill_after). I am thinking about making a special "call" case with receive timeout infinity and handle it with a middleman process or with trapping exits but that will render reply inconsistencies (call with infinity will return killed, call with timeout will return timeout)