Range formater and eslint formats the whole document

Question

Range formater and eslint formats the whole document

CiGit opened this issue 7 years ago · comments

Cyril Junod commented 7 years ago

By using eslintIntegration and the range formater, the whole document gets formatted.

Due to prettier-eslint not supporting this feature (yet?)

Alternative: Disable eslint with the range formater.

Robin Malfait · Answer 1 · Fri Jul 07 2017 04:44:02 GMT+0800 (China Standard Time)

There are multiple problems with format selection:

Because it gets re-printed and you select nested code, it will move everything to the left
if forgot to select a { meaning you have "invalid" code selected because it can not be printed in 1 go, it will fail. (this happens quite a lot in my case).
Why do we need this feature actually? If you work with an html file with script tags in it. Aren't there ways to only format that script block because that's the only part that can be formatted? Just thinking out loud.

Cyril Junod · Answer 2 · Sat Jul 08 2017 00:30:18 GMT+0800 (China Standard Time)

Have you tried the range formater recently ? @josephfrazier improved it a lot :-)
1 and 2 are past issues to me.
3. Prettier aims to support HTML in the future if I remember correctly. Sorry I've no source right now.

Robin Malfait · Answer 3 · Sat Jul 08 2017 05:25:14 GMT+0800 (China Standard Time)

Oh, I haven't used range formatting in a while now, ignore my comments :D

Cyril Junod · Answer 4 · Wed Jul 19 2017 16:52:51 GMT+0800 (China Standard Time)

I've some ideas:

Remove eslint support 😕
Use only prettier on range formatting 😑
As is, ie format document 😥
prettier-eslint supports range. 😆

Divyanshu Maithani · Answer 5 · Sat Dec 23 2017 00:46:44 GMT+0800 (China Standard Time)

Seeing this issue in latest vscode (1.19 release) on Fedora 27 linux x64. Reporting since this has been open since quite some time. I've to manually copy the seletion to a new js file, run prettier on it and then copy it back again at the moment 😅

Ninh Pham · Answer 6 · Mon Feb 12 2018 12:53:59 GMT+0800 (China Standard Time)

I've to do work-around by: Format whole document (Shift + Alt + F) -> copy the formarted block code -> Ctrl + Z -> Paste 😆😆

Season Chen · Answer 7 · Fri Aug 31 2018 17:35:35 GMT+0800 (China Standard Time)

I think this feature(selection format) is very necessary. Because in the multi project collaboration development of old projects, conflicts can be reduced. 😄 😄

Serhii Shmyg · Answer 8 · Sun Nov 11 2018 02:06:53 GMT+0800 (China Standard Time)

I've turned off "prettier.eslintIntegration": false but nevertheless format selection formats all document (

Cyril Junod · Answer 9 · Sun Nov 11 2018 19:44:47 GMT+0800 (China Standard Time)

Format selection formats the first common parent node which can act as a valid Program. This may be your entire file.

Mark Schlitz · Answer 10 · Sun Jul 14 2019 08:20:13 GMT+0800 (China Standard Time)

I've turned off "prettier.eslintIntegration": false but nevertheless format selection formats all document (

This was the only thing that worked for me. Unfortunate, but Format Selection is extremely useful for me.

njzy · Answer 11 · Mon Nov 04 2019 17:08:02 GMT+0800 (China Standard Time)

Still have this problem

zizhen · Answer 12 · Wed Nov 20 2019 11:22:16 GMT+0800 (China Standard Time)

Is there any solution for this problem?

Nathan Totten · Answer 13 · Tue Feb 04 2020 02:56:14 GMT+0800 (China Standard Time)

No, the issue is with prettier-eslint not supporting range formatting. The fix from our side would be to disable range formatting when eslint integration is enabled, but that's probably not something I am going to prioritize any time soon. Happy to accept a PR though.

It also seems like prettier-eslint is mostly a dead project so it is unlikely this will get fixed. I would suggest switching to the recommended approach of integrating ESLint and Prettier

github-actions · Answer 14 · Sun Jul 12 2020 15:08:43 GMT+0800 (China Standard Time)

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.