Add styles to options page
kaicataldo opened this issue · comments
Any preference of style technique? I was originally going to use Styled Components, but it seems like the Prettier site uses raw CSS.
No preference, as long as it's easy to maintain :)
@kaicataldo Would you like to try this? If not I can.
Feel free! I'm happy to work on it but I have some other things I need to work on right now and am not sure when I can get to it.
@nickmccurdy Just wanted to check in on how this is going. I don't have time to work on this right now, but I feel like we've stalled out while we're waiting for tests, and this issue is the biggest blocker for releasing v1.
Sorry, the tests were taking longer than I thought and I got distracted with other projects. I can prioritize these styles when I get back to working on this extension.
Do you have any preference over whether it should have a fancier theme possibly with Prettier's branding, or do we just want default browser UI components with better layout?
I think some basic styles is fine to start with! Nicely designed ones are always better, but we can iterate :)
Basic style that looks nice and aligned :)
One more friendly ping here. Would be great to get this sorted so we can release v1 :)
One more ping! I'll see if I can find some time to implement some styles if @nickmccurdy is not currently able.
Please do :)
I was trying to refactor the options components with Formik to make styling easier, since for styling purposes we'd likely have to change the markup for each quite a bit, which gets repetitive. It got more complex than I expected but I'll try to take another look at it soon. You're welcome to style it based on the current form markup if you prefer.
@nickmccurdy @kaicataldo I can take this up, if no one is working on this.
I recommend react-hook-form.com instead of Formik
That would be great!
cool.
@lipis This was the last open issue in the 1.0 milestone. Are we ready to close and release it?