Giters

pret / pokeemerald

Decompilation of Pokémon Emerald

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Multiple independent values in charmap.txt

luckytyphlosion opened this issue · comments

commented

Two examples

  • The constant values for sound effects and music are defined independently in charmap.txt and include/constants/songs.h, so for example, changing the value of SE_RAIN in songs.h, or possibly adding a new song won't reflect in the charmap.
  • Placeholder IDs are also defined independently, e.g. STR_VAR_2 is defined as FD 03 in the charmap and also as #define PLACEHOLDER_ID_STRING_VAR_2 0x3 in gflib/text.h. This means changing or adding placeholders requires ensuring that the constant value is exactly the same.
commented

Would it make sense for this one to have the charmap.txt depend on songs.h for relevant constants?