gbafix: Don't pad ELF files

Question

aplumafreak500 opened this issue 4 years ago · comments

If option -p is specified and the target file is an ELF, it will pad the ELF file. This shouldn't happen, as objcopy will pad it anyways.

A potential fix would be to ignore -p when the input is an ELF file, and possibly output a warning if this is the case.

rawr51919 · Answer 1 · Fri Jun 17 2022 23:08:49 GMT+0800 (China Standard Time)

Another possibility could be to just not use -p with ELF files

Martin Griffin · Answer 2 · Thu Jan 19 2023 06:16:01 GMT+0800 (China Standard Time)

Assuming sh_offset gets set to something non-zero, this seems to have been fixed in 2019: https://github.com/pret/pokeemerald/blame/master/tools/gbafix/gbafix.c#L297?