recent changes look terrible in the terminal:
mattly opened this issue · comments
Screenshot, terminal on left, macvim on right:
I'll take a look in a while, meantime I'm reverting to a previous commit for my own use.
Whoa. Must be related to either the linking refactor where I enforced consistency between the gui and term highlights. Sorry about that.
The problem persists even with your revert. Basically it comes down to cterm: italic. For whatever reason, it's displaying these "italics" as inverted. IDK if this is the intended behavior or not. So, I spent more time than I cared to looking at the state of terminal italics, and came away with the conclusion that computers suck, let's go live in the woods.
iTerm2 recently enabled italic support, but doing so requires jumping through some hoops, and doing so under tmux requires jumping through even more hoops, and even then that's assuming you're using a monospace font that has an italic set, which I don't. I'm inclined to simply remove the cterm: italic statements, however I think the right thing to do is have something in the helper function that will disable them based on a variable that you can set to have them enabled. Which is more work than I care to do at the moment, but perhaps this weekend.
actually, the patch was simple, forthcoming.
Great to hear. I had tested italics using https://github.com/reedes/vim-config/blob/master/misc/xterm-256color-italic.terminfo but didn't realize it required the additional hoop jumping.
and, done. I updated the readme with the option as well.