precice / dumux-adapter

Repository from Github https://github.comprecice/dumux-adapterRepository from Github https://github.comprecice/dumux-adapter

Inconsistent dockerfile recipes

mathiskelm opened this issue · comments

Description

The .slim and .large dockerfile recipes treat the argument PRECICEVERSION inconsistently. For the slim recipes it's used as a branch name in order to allow develop, which means release versions are built using e.g. v3.0.0. For the large recipe it is used to get the correct .deb package, which are named e.g. libprecice3_3.0.0_jammy.deb, thus requiring a variable of 3.0.0. As it stands that also impacts the tag the docker containers are uploaded with, though that could be unified to a changed v3.0.0 instead of 3.0.0 if desired.