Error in evaluating "build_v8_with_gn" on node-gyp v3.4.0 for Node target v10.x

[Francis Gulotta]

This is related to #221 and nodejs/node-gyp#1457 but specifically it's a failure to build node 10 binaries on node 8 when using prebuild --all The workaround for node-gyp is to pass --build_v8_with_gn=false to node-gyp. There isn't a way as far as I can tell to pass that through prebuild.

I'd work around this issue by running prebuild --all on node 10 but I hit #221 when I do that. Fixing this issue here is my best bet.

I don't believe there is a problem if we always pass --build_v8_with_gn=false

[ralphtheninja]

@reconbot Oh, thanks a lot for spending time on this! Need me or someone else to fix this or are you up for making a PR?

[Francis Gulotta]

I got a new baby at home so it might be a few days before I could take a crack at it

…

On Thu, Jul 19, 2018, 5:02 AM Lars-Magnus Skog ***@***.***> wrote: @reconbot <https://github.com/reconbot> Oh, thanks a lot for spending time on this! Need me or someone else to fix this or are you up for making a PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#222 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABlbjkdGn1yJI5s-84WjL9XSroCdFREks5uIEsIgaJpZM4VVucR> .

[ralphtheninja]

I got a new baby at home so it might be a few days before I could take a crack at it

Congrats! 👶 🍼

[Francis Gulotta]

Found time on the train home 🙃

…

On Sat, Jul 21, 2018, 8:21 AM Lars-Magnus Skog ***@***.***> wrote: Closed #222 <#222> via #223 <#223>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#222 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABlbq9dhHwy6e-Lc3EhAkX02YkF012rks5uIxzhgaJpZM4VVucR> .