prbinu / tls-scan

An Internet scale, blazing fast SSL/TLS scanner ( non-blocking, event-driven )

Home Page:https://prbinu.github.io/tls-scan

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

strings from certificate are broken

EnDe opened this issue · comments

commented

if the text in the certificate (i.e. issuer or subject) contains " (double-quote), they are removed from the output

Good catch!
Its a hack to avoid breaking JSON output. Yeah I could have escaped it, but that would be an expensive operation and require new buffer. I was thinking that that given a certificate fingerprint, we can easily find the certificate details. I would like to know your thoughts on this.

thank you!

commented

hmm, a computer is there to do what I want, not the other way around.
IMHO changing the string is a bug.
But wait, we're having "alternative facts" nowerdays :-/

Yes, this is less than ideal state, but low priority for now. I will try to address this when i get some time between my regular schedule.

This is now fixed in the latest (1.4.6) release