pqhieu / jsis3d

[CVPR'19] JSIS3D: Joint Semantic-Instance Segmentation of 3D Point Clouds

Home Page:https://pqhieu.com/research/cvpr19/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Did L_var term in discriminative loss forget to divide the batch_size?

kyuusaku opened this issue · comments

loss += torch.sum(var[i,:,:n]) / torch.sum(masks[i,:,:n])

      for i in range(batch_size):
            n = size[i]
            loss += torch.sum(var[i,:,:n]) / torch.sum(masks[i,:,:n])
      loss /= batch_size

Hi @kyuusaku,

Good catch, let me correct the code. I'm not sure it will have any impact on the performance though.