ppwwyyxx / OpenPano

Automatic Panorama Stitching From Scratch

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Typo where constant should follow config variable?

NicksonYap opened this issue · comments

Was going through the source code and found this line

ransac_inlier_thres = (shape1.w + shape1.h) * 0.5 / 800 * RANSAC_INLIER_THRES;

It's quite weird for the number 800 to appear here only
Probably it should be replaced with SIFT_WORKING_SIZE?
I'm really unsure

SIFT_WORKING_SIZE 800 # working resolution for sift

Such that it from:

ransac_inlier_thres = (shape1.w + shape1.h) * 0.5 / 800 * RANSAC_INLIER_THRES;

to:

ransac_inlier_thres = (shape1.w + shape1.h) * 0.5 / SIFT_WORKING_SIZE * RANSAC_INLIER_THRES;

The 800 here is unrelated to SIFT_WORKING_SIZE. It's merely a parameter and it can already be tuned by tuning RANSAC_INLIER_THRES.