do not toast if user has logged out
poundifdef opened this issue · comments
If a user specifically presses the "log out" button, it means that they do not want the app automatically doing updates or showing toast messages. We should keep track of whether the cache was invalidated because the user pressed "log out" or for some other reason - and if it is the former, make the app as non-invasive as possible
Setting the cache prefs outgoingCallPrefTitle and incomingCallPrefTitle to false on logout would take care of that. But what do you think about restoring those settings after successful login?
I think a better way would be to keep another pref, along the lines of hasManuallyLoggedOut. That gives the app the flexibility to behave differently depending on the user's intention - "NO I don't want you to save my login information so stay out of my way." (This is in response to feedback I have gotten on the app, and a legitimate concern - I get emails every week asking whether I do funny business with their login information.)
Also, out of curiosity, what's the use case for the Logout button? I can't think of a reason I'd want to use it, but I imagine someone might ...
re: funny business: that was my question, too :) Open source for the win.
The use case is primarily for people who want to remove their login information from the phone. This gives users full control of whether or not their personal information is saved - which is unnerving for both paranoid developer-types and people who have a healthy skepticism about giving apps their personal information properly.
Not everybody will have the inclination or expertise to trawl through the source code - so I think it's important to demonstrate that our app is trustworthy by allowing them to invalidate the cache.
Plus: I think as the app gains more features (I received a patch for a quick-and-dirty widget), "Sign out" will really double as a "disable this app" function for people who spend a lot of time trying to conserve memory (though I don't think there's much evidence that manually managing those settings helps a whole lot) or don't want to deal with $feature for whatever reason.
Re reasons for logout: That makes sense, thanks for the explanation.
hasManuallyLoggedOut++. good idea.
Re the widget patch: awesome. can't wait to see it.
@poundifdef This has been dead for over a year, am I correct in thinking this should be Closed FIXED?
Huh, can't believe it's been a year. The current iteration of the app does some fancy caching, but I don't think it disables toasts if the user has logged out (will need to check, though.)
There is currently a rewrite underway - now that we have a handle on exactly what issues this app faces, we can architect something better. If you're interested in contributing, I can put something on the wiki (or write you a note) for how to contribute to that branch.