Giters

pounard / goat-query

Goat SQL query builder built over a PHP to SQL and SQL to PHP type converter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Always cast array values

pounard opened this issue · comments

commented

Task of #58

Array when formatted and sent to PostgreSQL should always be casted using the array nested value type.

commented

Let's move this to 4.x, array have never been automatically cast previously, this is a known limitation/bug, but with the explicit CastExpression, users can now work around it.

Doing this properly will need more generic handling around converters:

  • declare an additional boolean property on ValueExpression to determine if the value requires a cast in the generated SQL,
  • and I don't know where to plug this to force the property to be cast. Right place seem to be the converters, but it's not converter job to know anything about SQL itself except for value parsing, so I guess it'd be the formatter itself.