Server crash on bad uri

Question

Server crash on bad uri

brenda opened this issue 11 years ago · comments

When get this uri:
/index?created_at=20130730T173924}
the server chash!

/Users/user/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:176:in split': bad URI(is not URI?): /index?created_at=20130730T173924} (URI::InvalidURIError) from /Users/user/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:211:inparse'
from /Users/user/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:747:in parse' from /Users/user/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:994:inURI'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/request.rb:90:in parse_header' from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/connection.rb:34:inblock in post_init'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/connection.rb:63:in call' from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/connection.rb:63:in<<'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/connection.rb:63:in receive_data' from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/eventmachine-1.0.3/lib/eventmachine.rb:187:inrun_machine'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/eventmachine-1.0.3/lib/eventmachine.rb:187:in run' from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/em-synchrony-1.0.3/lib/em-synchrony.rb:38:insynchrony'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/server.rb:73:in start' from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/runner.rb:304:inrun_server'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/runner.rb:224:in run' from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/application.rb:111:inrun!'
from /Users/user/.rvm/gems/ruby-2.0.0-p247@my_app/gems/goliath-1.0.3/lib/goliath/application.rb:133:in `block in module:Goliath'

Ilya Grigorik · Answer 1 · Sat Aug 03 2013 04:38:32 GMT+0800 (China Standard Time)

What's the full request to the server?

Brenda · Answer 2 · Sat Aug 03 2013 04:43:28 GMT+0800 (China Standard Time)

GET "http://localhost:9000/index?created_at=20130730T173924}"

Ilya Grigorik · Answer 3 · Sat Aug 03 2013 04:51:42 GMT+0800 (China Standard Time)

Thanks. Well, the "}" is an invalid character, so the error is correct - it should be escaped.

We definitely shouldn't crash the server (needs to be fixed), but the most we can do here is return a 500.. so you will still need to fix whatever is generating this request.

Brenda · Answer 4 · Sat Aug 03 2013 04:58:08 GMT+0800 (China Standard Time)

Yes, I am aware that te request is badly escape, but it shouldn't crash the server. I tried catching the exception but couldn't find exactly where, is there any way i could capture the exception to not make the server crash? or should i wait till you get it fixed?
Thanks

Larry Zhao · Answer 5 · Tue Jun 17 2014 16:56:16 GMT+0800 (China Standard Time)

This still happens to me in Goliath 1.0.3. Is there a patch for this or how could I catch it to avoid a server crash?

Ilya Grigorik · Answer 6 · Mon Jun 23 2014 02:53:10 GMT+0800 (China Standard Time)

Looks like we're (well) overdue for a 1.0.4. release.

@nolman @dj2 any objections?

Nolan Evans · Answer 7 · Mon Jun 23 2014 03:04:46 GMT+0800 (China Standard Time)

Looked at the changes, LGTM

Ilya Grigorik · Answer 8 · Mon Jun 23 2014 03:11:36 GMT+0800 (China Standard Time)

Awesome, thanks! 1.0.4 should be live.