postlund / search-card

Quickly search for entities from a Lovelace card.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No icon as of 0.110

m1ke-hub opened this issue · comments

commented

Nothing dramatic - just wanted to let you know the icons don't show as of HA 0.110. Probably related to this https://www.home-assistant.io/blog/2020/05/20/release-110/#icons

Yeah, seems to be the case. Will have to look into that in due time.

commented

No hurry - doesn't bother me at all

@migo-dev @postlund I managed to fix this locally by replacing 'iron-icon' with 'ha-icon' and changing the 'paper-icon-button' to a standard 'paper-button' and putting the ha-icon inside the element

@migo-dev mind closing this (I forgot to mention before it was merged, so not auto-closed)?

I think "Fixes #..." must be part of the commit message or PR body for that to work. So that's probably why it didn't work.

commented

Hey guys, thank you very much. Great improvement! Also thanks for the custom placeholder text 😄
I found a way to get the old close icon back:

[Lines 61-65]

        <ha-icon-button slot="suffix"
                          @click="${this._clearInput}"
                          icon="mdi:close"
                          alt="Clear"
                          title="Clear"></ha-icon-button>

BTW: which part is "responsible" for the small extra x?

which part is "responsible" for the small extra x?

That's the built-in browser behavior.

commented

Thanks, I see.. is there a way to hide it?

@migo-dev ???
btw made a new issue for that