shift-cmd-M Keyboard shortcut does not work as expected
austinjaney opened this issue · comments
shift-cmd-M keyboard shortcut does not work as expected when viewing TiddlyResearch in chrome or TiddlyDesktop and editing a Tiddler.
Expected Behavior: Highlighting marks added
Actual Behavior: opens chrome multiuser switcher
Remapping the keyboard shortcut does not change the behavior but does work correctly in some instances such as adding a Node Note.
I just tried this shortcut and it worked as expected.
I didn't know about the conflict on google chrome, but since you can edit the keyboard shortcut in the control panel, I am not going to change it for the moment.
About the remapping:
Are you on Windows or MacOS?
If you are on windows you will need to change Keyboard shortcuts > highlight > Non-Macintosh platforms only
If you are on mac you will need to change Keyboard shortcuts > highlight > Macintosh platforms only
(I noticed that the popup for the configuration can't be edited when in Krystal view, you can edit it only if you maximize the tiddler or make the tiddler size bigger. I'm going to fix it with the next update.)
I am on a mac, although I was able to replicate my findings on a pc as well using the ctrl+shift+M key combo on https://kebifurai.github.io/TiddlyResearch/
I can't seem to replicate the same issue in my other TiddlyWiki's. So far, I can rule out the following as a cause since I have them working in another wiki's:
- tiddlyresearch-design: theme tiddlers
- tiddlyresearch-sidebar: sidebar tiddlers
- datepicker: datepicker plugin for tiddlywiki5, based on Pikaday version 1.6.1
- moment: moment.js plugin for TiddlyWiki5
- Project Manager: Simple project managment for Tiddlywiki
- Krystal: (tiddlyresearch's fork) Horizontal Story River
- relink: Relink - flexibility when relinking renamed Tiddlers
I can also say a similar thing happens in Firefox when I remap the key combo , I get a popup that looks like:
on the https://kebifurai.github.io/TiddlyResearch/ I get no response at all.
I cannot replicate the issue you are having, are you sure you are using the shortcut when the node editor is opened?
Here's a quick gif that shows that the shortcut is working on https://kebifurai.github.io/TiddlyResearch:
I think I figured out the problem here. The mark shortcut doesn't work for me when the Tiddler is open for editing. So I can't use the shortcut in both the regular Tiddler edit area and any node editing areas if the Tiddler is being edited. If I take the Tiddler out of edit mode, then the shortcuts do indeed work when editing nodes.
This problem seems to affect all of the editing keyboard shortcuts (i.e. italics, bold, headings, etc)
BTW, thanks for your work on this. It's already very useful and extremely promising.
Interestingly, I can make each shortcut start working when a Tiddler is open for editing by making enabling its editor toolbar button. This doesn't fix all of the editing shortcuts, but only the shortcuts matching the buttons I enabled.
Thanks @professionalPeter for you explanation.
I decided to disable the default editor toolbar buttons by default since tiddly research focuses on single nodes.
Re-activating them also re-enables the shortcuts to work in the default editor.
Thanks for your explanation too. Just to be clear, the shortcuts are also disabled in the node editor when the regular Tiddler editor is open. Obviously, I can, and will, close the regular Tiddler editor and happily use the shortcuts in the node editor, but as a newcomer I didn't realize that having that regular editor open was preventing the shortcuts from working.
Now that I go back and watch the tutorial again I realize that you were always editing nodes with the regular Tiddler editor closed, but as someone new to this I didn't immediately notice that. So my workflow was something like:
- Create new tiddler
- Create a new node
- Start editing the node (while wondering why shortcuts aren't working)
where it needs to be:
- Create new tiddler
- Save Tiddler (thus closing the Tiddler editor)
- Create a new node
- Start editing the node (enjoy the happiness and joy of the shortcuts)
Anyway, everything is working now for me, so thanks. I'm just passing this along in case it's helpful to you.
I only tested the shortcuts in the streams editor without realizing that they were not available in the default one.
In the next update I'm going to restore the editor toolbars that have custom shortcuts so that you can use them everywhere.
Thanks for the feedback!
I only tested the shortcuts in the streams editor without realizing that they were not available in the default one.
In the next update I'm going to restore the editor toolbars that have custom shortcuts so that you can use them everywhere.
Thanks for the feedback!
Fixed with v1.3