Giters

posthtml / posthtml-url-parameters

Add parameters to URLs with PostHTML.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade is-url-superb to 4.0.0 to fix a bug

jaddison opened this issue · comments

commented

Problem

Described here in the Maizzle project; template variables in a URL break Maizzle's urlParameters functionality.

Environment

  • posthtml-url-parameters plugin version: 1.0.2
  • PostHTML version: 0.13.0
  • Node.js version: 13.8.0

The Test + Fix

Looks like the fix is to upgrade is-url-superb from 3.0.0 to 4.0.0; this code returns false with 3.0.0, but true with 4.0.0 (I used repl.it):

require('is-url-superb')('https://example.com/{{ var }}')
commented

Reopening this as it has not been actually solved, see failing test in 4c6994b