posthtml / htmlnano

Modular HTML minifier, built on top of the PostHTML

Home Page:https://htmlnano.netlify.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade to "uncss": "^0.17.0"

sqrter opened this issue · comments

Usually, I update all dependencies right before releasing a new version.

Does uncss 0.17.0 have some new features that worth releasing a new version earlier? If so, can you please re-open this issue post them here?

Hi @maltsev, thank's for the quick response! I'm using htmlnano along with its "removeUnusedCss" module and it's really awesome. However, in my case, I must tell uncss to not process external scripts in my html. The latest uncss allows passing the needed option to jsdom that is used behind the scenes.

You can have a look at the release notes of uncss here https://github.com/uncss/uncss/releases/tag/0.17.0

Just let me know if I could help with preparing a pull request :)

PS. I could solve my issue by just using

  "resolutions": {
    "uncss": "^0.17.0"
  }

so you're right, it can definitely wait for some more meaningful release.

Just let me know if I could help with preparing a pull request :)

No need :-) I just updated this and other dependencies.

it can definitely wait for some more meaningful release.

Great! Then I will not release a new version just with these changes.