No TSIOBufferReaderCopy interface

Question

No TSIOBufferReaderCopy interface

hy05190134 opened this issue 10 years ago · comments

TSIOBufferReaderCopy(meta_reader, &mdhd64, sizeof(mp4_mdhd64_atom));
TSIOBufferCopy(mvhd_atom.buffer, meta_reader, atom_size, 0);

mp4_meta.cc use a lot of TSIOBufferReaderCopy to deep copy string into meta_reader, but the interface is deprecated maybe. So can I use code below to take place of the code above ?

TSIOBufferWrite((TSIOBuffer) meta_reader, &mdhd64, sizeof(mp4_mdhd64_atom))

portl4t · Answer 1 · Mon Dec 29 2014 16:45:14 GMT+0800 (China Standard Time)

Absolutely not, the two functions have different use. As described in InkAPI.cc, TSIOBufferReaderCopy(...) was not in SDK3.0. There is not evidence said that this function was deprecated.

portl4t · Answer 2 · Mon Dec 29 2014 17:56:34 GMT+0800 (China Standard Time)

Without TSIOBufferReaderCopy(...), you have to iterate all the block within the MIOBuffer to deep copy the string.

portl4t · Answer 3 · Tue Dec 30 2014 18:26:54 GMT+0800 (China Standard Time)

Hi hy05190134, I think your are right, TSIOBufferReaderCopy(...) was a private api in master, I had fix this issues by changing TSIOBufferReaderCopy(...) to IOBufferReaderCopy(...). Thanks for your advice.