Timeout issue when using with Bun
lnlife opened this issue Β· comments
I created a simple http server with http.createServer
, and query database when requests come:
let rows = await sql.unsafe(query, args, { prepare: true })
After starting the server it works fine at beginning. But if do not send request after a while (maybe 1+ hour), then send request again, got query timeout:
22 | errno: x,
23 | address: options.path || host
24 | }, options.path ? {} : { port: port }
25 | )
26 | Error.captureStackTrace(error, connection)
^
error: write CONNECT_TIMEOUT localhost:5432
code: "CONNECT_TIMEOUT"
at connection (/home/test/node_modules/postgres/src/errors.js:26:9)
at connectTimedOut (/home/test/node_modules/postgres/src/connection.js:433:14)
at done (/home/test/node_modules/postgres/src/connection.js:1035:12)
This issue only occurs on Bun, not on Node.(I've tested both)
You can install from github by using porsager/postgres#commithash
v3.4.4 released
@porsager a new bug may have been introduced, now when calling postgres.end({timeout: 30})
it never completes until the timeout on my Bun app
please test with node and let me know if there's an issue. If there is only an issue with bun you need to file it in the bun repo.
@porsager I'll see if I can reproduce with node, but at least on Bun this is definitely a regression between 3.4.3
and 3.4.4
. I rolled back to 3.4.3
and the connection terminates instantly instead of waiting for the timeout.
right, the "workaround" solving the previous bun error probably shouldn't have been made, and instead solved in bun instead π
So from now on I'm not taking bug reports from bun anymore π Bun has stated "many" times, that things working in node should work in bun, and bug reports should go to the bun repo then.
@porsager
seems that "workaround" might be the issue. getting this so frequently now.
Bun 1.1.0 | PostgresJs 3.4.4 | drizzle-orm 0.30.6
You should go thumb up that issue on bun ;) oven-sh/bun#7325
The fix for this will land in Bun v1.1.7, which we aim to release in a few hours
Hmm... the issue with not properly closing the connection for me is present even in Bun v1.1.8. Does it work for you @evelant? π€
I haven't tried it yet, sorry
No worries, in case you have time, you could check so I can be sure that I'm not the only one π
@wiesys I'm using Postgres.js 3.4.4 on Bun 1.1.8 and the issue is still present.
The fix for this will land in Bun v1.1.7, which we aim to release in a few hours
@Jarred-Sumner Its still there. oven-sh/bun#7325 (comment)