Missing countries

Question

Missing countries

hersche opened this issue 5 years ago · comments

Hey,

thanks for your work. I found that serbia is not existing in your project yet and therefore not found. Would be nice if this is included.

https://en.wikipedia.org/wiki/Serbia

If you would prefer a PR with a such json, let me know and i will take the time.

Porimol Chandro · Answer 1 · Sun Dec 22 2019 22:17:36 GMT+0800 (China Standard Time)

Hey @hersche ,

Please make a PR.

Tommy Carstensen · Answer 2 · Wed Mar 18 2020 13:47:46 GMT+0800 (China Standard Time)

Great stuff guys. The following countries (or synonyms) seem to be missing:
Andorra
Bahamas
Brunei Darussalam
Congo
Cote dIvoire
Eswatini
Holy See
Kosovo
Myanmar
North Macedonia
Palestine
Serbia
United Republic of Tanzania
United States of America

Porimol Chandro · Answer 3 · Wed Mar 18 2020 14:13:28 GMT+0800 (China Standard Time)

Hey @tommycarstensen ,

Thanks for your interest!

Would you please make PR!

Yannick Misteli · Answer 4 · Mon Apr 06 2020 20:14:16 GMT+0800 (China Standard Time)

United States of America => 'United States'

Vinzenz Hersche · Answer 5 · Wed Apr 22 2020 16:06:44 GMT+0800 (China Standard Time)

I will change the title then to "Missing countries".

@porimol did you saw my PR? Hope it's fine as it is.

Porimol Chandro · Answer 6 · Wed Apr 22 2020 18:08:52 GMT+0800 (China Standard Time)

Hey @hersche ,

Sorry, I was a little bit busy. ASAP, I'll review and merge.

David Jones · Answer 7 · Fri May 01 2020 17:38:50 GMT+0800 (China Standard Time)

Hey @hersche ,

Sorry, I was a little bit busy. ASAP, I'll review and merge.

Is there any news on this PR? I love this library but adding these countries would be great!

Porimol Chandro · Answer 8 · Sat May 02 2020 13:55:37 GMT+0800 (China Standard Time)

Hi @hersche,

Merged your PR.

Thanks :)