polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

App crashed render issues on history

VitoItalianGamer opened this issue · comments

Checklist

  • I am able to reproduce the bug with the latest version.
  • I am not able to reproduce the bug with the same version of upstream NewPipe.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.1

Steps to reproduce the bug

  1. Go to history
  2. Scroll down
  3. Play video
  4. Rotate back and forth
  5. Minimize video
  6. Then scroll up when rendering issues happen

Expected behavior

Does not have rendering issues when scrolling up and does not crash.

Actual behavior

When scrolling up the app crashes

Screenshots/Screen recordings

Screenshot_20230723-124219

Logs

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en-US
  • App Language: en_US
  • Service: none
  • Version: 0.25.1
  • OS: Linux motorola/tonga_g/tonga:12/S3RQ32.20-42-10-3/aab62:user/release-keys 12 - 31
Crash log

java.lang.IllegalStateException: ViewHolder views must not be attached when created. Ensure that you are not passing 'true' to the attachToRoot parameter of LayoutInflater.inflate(..., boolean attachToRoot)
	at androidx.recyclerview.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:7297)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6416)
	at androidx.recyclerview.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:288)
	at androidx.recyclerview.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:345)
	at androidx.recyclerview.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:361)
	at androidx.recyclerview.widget.GapWorker.prefetch(GapWorker.java:368)
	at androidx.recyclerview.widget.GapWorker.run(GapWorker.java:399)
	at android.os.Handler.handleCallback(Handler.java:978)
	at android.os.Handler.dispatchMessage(Handler.java:104)
	at android.os.Looper.loopOnce(Looper.java:238)
	at android.os.Looper.loop(Looper.java:357)
	at android.app.ActivityThread.main(ActivityThread.java:8103)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1026)


Affected Android/Custom ROM version

Android 12

Affected device model

Moto G Power (2022)

Additional information

The screen has rounded corners.

commented

What happens when you do the same in:

  1. Regular NewPipe with the same settings as NewPipe Sponsorblock
  2. A clean install of regular NewPipe
  3. A clean install NewPipe Sponsorblock (wipe data, back up settings etc. first)

It happened on another device and might work the same.